Christian Semmler
e9c322fddc
Fix
2026-03-13 07:58:48 -07:00
foxtacles
004e3b3bbf
Fix bugs ( #16 )
...
* Fix camera drifting during multi-part emotes
Block translational movement in HandleCameraRelativeMovement() when
a multi-part emote is active. Previously, movement input was processed
unconditionally, causing the native ROI (and camera) to move forward
while the display ROI stayed pinned at the emote position. Now the
emote check forces hasInput=false and zeros m_smoothedSpeed so neither
position updates nor coasting occur during any phase of a multi-part
emote. Camera orbit controls (rotation/pan/zoom) remain unaffected.
https://claude.ai/code/session_01QMcZSa3ysdyACVea66QA5K
* Fix use-after-free crash in NameBubbleRenderer::Update
Lego3DSound::FUN_10011a60 (used by LegoCacheSound::Play) did not reset
m_isActor and m_enabled when reassigning the ROI reference. When a
cached sound was reused — first for a known actor name (setting
m_isActor=TRUE), then for a multiplayer clone found via FindROI — the
stale m_isActor flag caused Reset() to call ReleaseActor on the clone's
ROI, freeing it while ThirdPersonCamera still held a pointer. The next
Tick then dereferenced the dangling pointer in NameBubbleRenderer::Update.
Reset the ownership flags at the top of the reassignment path so they
match the clean-state semantics of Lego3DSound::Create.
Also guard multi-part emotes behind an active 3rd-person camera check
and remove a leftover debug log in RemotePlayer.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-03-13 04:52:58 +01:00
Christian Semmler
3017cd24e0
Fix: missing pending action reset on background audio start failure ( #684 )
2025-08-19 23:36:20 +00:00
Christian Semmler
d10ac7e77c
Add hdmusic.si asset pack, extend SiLoader with Replace directive ( #671 )
...
* Replace SI objects
* Changes
* Fix
* Remove obsolete file
* Add delete handler
* Updates
* Update assets
* Configure git LFS
* Add HD music
* Move files to LFS
* chmod files
* fix gitattributes
* Fixes
* Fixes
* Add other HD music
* Fix file perms
* Add comment
* Minor update
* Refactor
* Fix
* Add LFS flag
* Add check for file replace
* Exclude assets from CPack
* Attempt fix
* Update libweaver
* Fix MxDSBuffer leak
* Add .lfsconfig
* Set LFS URL
* Fix LFS CI
* Fix
* Space
2025-08-16 21:21:39 +02:00
Christian Semmler
0f1b8e8430
Merge remote-tracking branch 'isle/master'
2025-08-10 13:16:30 -07:00
MS
2fc48b620e
Dead code in MxBackgroundAudioManager ( #1668 )
...
* Dead code in MxBackgroundAudioManager
* Rename
2025-08-06 14:23:48 -04:00
MS
48b922d8f0
Add dead code from LegoCacheSound ( #1667 )
...
* Dead code from LegoCacheSound
* Use windef.h typedefs
2025-08-05 22:57:17 -04:00
Christian Semmler
72dae4dd52
Merge remote-tracking branch 'isle/master'
2025-07-29 16:47:18 -07:00
jonschz
a9e261606d
Fix mxomni.* file names ( #1654 )
...
Co-authored-by: jonschz <jonschz@users.noreply.github.com>
2025-07-25 22:19:09 +02:00
jonschz
03adac0c58
Match LegoOmni::Create(), other BETA10 matches ( #1651 )
...
* Match `LegoOmni::Create()`, other BETA10 matches
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com>
2025-07-25 17:13:34 +02:00
Christian Semmler
c774a8edde
Merge remote-tracking branch 'isle/master'
2025-07-23 13:21:39 -07:00
jonschz
36f6d963dc
BETA matches for SoundManagers ( #1646 )
...
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com>
2025-07-21 23:42:42 +02:00
Christian Semmler
6a45dbec34
Merge remote-tracking branch 'isle/master'
2025-07-20 09:25:06 -07:00
jonschz
6b5f3724c0
Beta match MxAutoLock and MxCriticalSection ( #1638 )
...
Co-authored-by: jonschz <jonschz@users.noreply.github.com>
2025-07-20 07:57:26 +02:00
Anonymous Maarten
e813a12a4a
Fix notification/presenter casts ( #1532 )
...
* LegoCarBuild: cast c_notificationType0 to MxNotificationParam
* MxBackgroundAuioManager gets a MxWavePresenter
2025-05-30 21:43:33 +02:00
Anonymous Maarten
58b5a2b96d
Allow entering helicopter build minigame ( #204 )
...
* LegoCarBuild: cast c_notificationType0 to MxNotificationParam
* MxBackgroundAuioManager gets a MxWavePresenter
2025-05-30 19:23:54 +00:00
Christian Semmler
26cd442d95
Merge remote-tracking branch 'isle/master'
2025-05-24 08:12:54 -07:00
Florian Kaiser
90b5c27a8b
Clear unknowns in MxBackgroundAudioManager ( #1516 )
...
* Clear unknowns in `MxBackgroundAudioManager`
* Apply suggestions from code review
---------
Co-authored-by: Christian Semmler <mail@csemmler.com>
2025-05-24 06:49:43 -07:00
Christian Semmler
3192eb551a
Add MxMiniaudio wrapper to fix resource issues ( #131 )
...
* Add `MxMiniaudio` wrapper to fix resource issues
* Fix naming
* Updated wrapper
* Use implicit cast
2025-05-20 02:07:20 +02:00
Christian Semmler
b1623302c9
Merge remote-tracking branch 'isle/master' into mergeisle8
2025-05-12 08:39:16 -07:00
Florian Kaiser
e59345c88c
Rename SetUnknown84 to SetNotificationObject ( #1474 )
2025-05-12 17:20:38 +02:00
Christian Semmler
9d01f67abb
Merge remote-tracking branch 'isle/master' into mergeisle4
2025-04-06 08:36:09 -07:00
Christian Semmler
401fa7674e
Match MxBackgroundAudioManager::FadeInOrFadeOut ( #1413 )
2025-03-16 22:19:11 +01:00
Christian Semmler
622f00f628
Merge remote-tracking branch 'isle/master' into mergeisle3
2025-03-14 13:59:52 -07:00
jonschz
87d13aa277
Add various BETA10 references and fixes ( #1398 )
...
Co-authored-by: jonschz <jonschz@users.noreply.github.com>
2025-03-02 19:59:03 +01:00
Christian Semmler
44d131ad18
Merge from isledecomp/isle
2025-02-17 17:52:38 -07:00
jonschz
777dfa82ec
Match Infocenter::HandleControl ( #1386 )
...
* Add BETA10 references
* Refactor non-existent getters
* Infocenter::HandleControl maybe down to entropy
* Rename variable
* More refactoring
* Refactor public variable
* 100 %
* Fix clang-format
* Fix clang-format
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com>
Co-authored-by: Christian Semmler <mail@csemmler.com>
2025-02-18 01:12:51 +01:00
Christian Semmler
5a6482c6cf
Merge remote-tracking branch 'isle/master' into mergeisle
2025-02-02 08:38:16 -07:00
MS
dad44535bd
Beta matching LegoCacheSound ( #1379 )
2025-01-29 10:41:50 -05:00
Christian Semmler
00dee618c0
Merge remote-tracking branch 'isle/master' into mergeisle
2025-01-22 16:34:28 -07:00
Christian Semmler
fc03e7a682
Improve order until legomain.cpp ( #1350 )
...
* Fix `LegoBackgroundColor` order
* Order
* Improve order in Act3Actors
* Improve order
* Add BETA annotation
* Order more
* More order
* More order
* Order
* Match/order
* Remove blank line
* Modern compiler fix
* vtable annotation
2025-01-17 18:33:27 -07:00
Christian Semmler
07655651f5
Convert DirectSound logic to miniaudio ( #34 )
...
* Convert DirectSound logic to miniaudio
* Update legocachsound.cpp
2024-12-14 20:36:13 -07:00
Christian Semmler
d22c4cd1f2
merge from isle/master
2024-12-07 10:17:25 -07:00
MS
7ece9cf37b
Fix MxParam casts in Notify functions ( #1188 )
...
* First batch
* Second batch
2024-12-03 15:51:03 -07:00
Christian Semmler
a0a114135a
Implement/match LegoAct2::HandleEndAction and related ( #1184 )
...
* Implement/match LegoAct2::HandleEndAction
* Reorder
2024-12-02 18:58:08 +01:00
Christian Semmler
5ade193261
merge from isle/master
2024-11-29 15:27:01 -07:00
Christian Semmler
b9a1da6a7a
Implement/match Act2Brick ( #1169 )
...
* Implement/match Act2Brick
* Rename functions
* Naming
2024-11-25 22:08:57 +01:00
Christian Semmler
bb36eda0dd
Merge remote-tracking branch 'isle/master'
2024-11-14 13:42:52 -07:00
jonschz
71a7498481
Implement most of JetskiRace, add BETA10 annotations ( #1149 )
...
* Implement most of `JetskiRace`, add BETA10 annotations
* Fix declaration order issue
* Clean up FUN_10012de0
* Fix regression
* Address review comments
* Address another review comment
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com>
2024-11-14 21:42:38 +01:00
jonschz
6cda0d95c7
Complete LegoCarBuild ( #1144 )
...
* Complete `LegoCarBuild`
* Fix match error
* Address review comments
* Fix regression
* Fix minor sign comparison issue
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com>
2024-11-11 15:44:03 +01:00
Christian Semmler
9f9294694d
Merge remote-tracking branch 'isle/master'
2024-11-09 10:11:57 -07:00
jonschz
c65bc67e3d
Implement FUN_10025720() and others ( #1134 )
...
* Implement `FUN_10025720()` and others
* Address review comments, get 100 %
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com>
2024-11-05 21:33:51 +01:00
Christian Semmler
bf5379992e
merge from isledecomp/isle
2024-10-26 08:06:31 -07:00
jonschz
c38e157fdb
Implement LegoCarBuild functions, refactor BackgroundAudioManager ( #1117 )
...
* Implement LegoCarBuild functions, refactor BackgroundAudioManager
* Refactor LegoVehicleBuildState::m_animationState to enum
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com>
2024-10-25 09:04:01 -07:00
Christian Semmler
318c46b881
merge
2024-09-05 12:09:19 -07:00
jonschz
2b14d3d6a5
Implement parts of LegoCarBuild and dependents ( #1092 )
...
* Implement parts of `LegoCarBuild` and dependents
* Fix BETA10 offset
* Fix constants
* Code style: Rename parameters
* Linter fixes v2
* Linter errors v3
* Add BETA10 variable names for presenters
* Address review comments
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com>
2024-09-03 13:50:30 -07:00
Christian Semmler
806afaa210
Replace DirectSound with miniaudio ( #21 )
...
* Add miniaudio
* WIP
* static const
* Fix missing looping
* Fix volume
* Implement 3D sound, WIP
* Remove unused WinMM code
* Update README.md
* Fixes
* Fix naming
* Fix naming
* disable ma threading
* Invert Z axis for OpenGL system
* Update comment
* Set rolloff
* Fix minimize/maximize suspension
* Rename function
* SDL3: changed macro name
2024-06-25 20:02:58 +02:00
Christian Semmler
0c7c77aad3
Implement/match LegoActor::Mute ( #992 )
2024-06-04 12:19:59 -04:00
Christian Semmler
4898a55508
Match LegoCacheSoundManager::FindSoundByKey ( #991 )
...
* Match LegoCacheSoundManager::FindSoundByKey
* Remove space
2024-06-04 18:05:01 +02:00
Christian Semmler
828b35e9d2
Implement/match LegoCacheSound::Play and Lego3DSound::FUN_10011a60 ( #987 )
...
* Implement/match LegoCacheSound::Play and Lego3DSound::FUN_10011a60
* Update names
* Update
2024-06-02 17:09:09 +02:00
