* Add multiplayer extension
* Fix animation system to work when host is outside ISLE world
- Move TickHostSessions outside m_inIsleWorld gate so the host can
coordinate animations from any world
- Load animation catalog early in HandleCreate so the host can
coordinate before entering the ISLE world
- Use network-reported positions for remote player location detection
instead of requiring spawned ROIs
- Always erase sessions at launch — the host's job ends when the
animation starts; clients play and complete independently
- Replace BroadcastAnimComplete with locally-driven completion
callbacks: host generates eventId at launch, clients cache
completion JSON at start time, fire it when ScenePlayer finishes
- Make StopAnimation only do local cleanup (stop playback, cancel
own interest, reset coordinator) without destroying the session
host, so other players' sessions survive world transitions
- Broadcast state=0 in ResetAnimationState for full teardown paths
(shutdown, reconnect, host migration) so clients aren't left with
stale session state
* Fix use-after-free crash in ScenePlayer when remote player disconnects mid-animation
When a remote player's ROI is destroyed (disconnect, timeout, or respawn),
notify all active ScenePlayer instances to null out dangling references
before the ROI is freed. The animation engine already handles null ROI map
entries gracefully, so playback continues for remaining participants.
* Fix crash when performer's child ROIs are left dangling in ScenePlayer
NotifyROIDestroyed now walks the parent chain to also invalidate child
ROIs of the destroyed performer (head, limbs, etc.) that were placed
into the roiMap by BuildROIMap. The ancestor walk happens once; all
other fields are cleaned with simple pointer equality.
* Allow spectator to play click animation during scene playback
* Make PTATCAM track spectator ROI instead of camera in ScenePlayer
* Only regenerate emscripten version files when git state changes
Replace add_custom_target(ALL) with add_custom_command(OUTPUT) so the
version script only runs when .git/HEAD or the current branch ref file
changes, instead of on every build.
* Fix ROI name collision causing dangling pointers in NPC locomotion roiMaps
When ScenePlayer created cloned NPC ROIs for cooperative animations, it
renamed them to match the original character name and added them to the
ViewManager. This created a name collision: two ROIs with the same name.
The original game's AppendROIToScene searches by name and stops at the
first match, so if a locomotion BuildROIMap ran while the clone existed,
it could capture pointers to the clone's child ROIs. When the clone was
later destroyed (CleanupProps), those roiMap entries became dangling
pointers, crashing in AnimateWithTransform at roi.h:151 (SetVisibility).
Fix: use the alias mechanism (already supported by AnimUtils::BuildROIMap)
instead of renaming clones. Also unify all ROI name generation behind a
shared counter to prevent character manager key collisions.
* cmake+ci: run clang-tidy
* Remove DESCRIPTION from LEGO1/LegoOmni.mingw.def
* Add initial .clang-tidy and fixes
* fix file perms
* Comment out DESCRIPTION
* Remove LegoEntity::~LegoEntity and MxPresenter::~MxPresenter from mingw's LEGO1.def
* Looks like clang is allergic to the libs in the directx5 SDK
* Update .clang-tidy
* Fix typo in .clang-tidy
* Attempt to generate an action error
* Revert "Attempt to generate an action error"
This reverts commit 96c4c65fedbc4102837f4bcbbb9ee83a7d14cba3.
* cmake: test with -Wparentheses + optionally with -Werror
* ci: -k0 is a Ninja argument
* Use -Werror only for msys2 builds
* cmake: only emit warnings for specific warnings
* cmake: and don't do -Werror/-WX anymore
* Fix warnings
* Fix mingw warnings
---------
Co-authored-by: Christian Semmler <mail@csemmler.com>
