Commit Graph

1536 Commits

Author SHA1 Message Date
Fabian Neundorf
356c64ce0e
Name state field, getter and setter in Act1State (#1621) 2025-07-13 12:01:06 -07:00
jonschz
40c1a40d2b
Match FUN_1006b140() and related functions (#1623)
* Match on BETA10

* Possible improvement on Matrix4::Swap

* Document entropy build result

* Comments at at Matrix4::Invert

---------

Co-authored-by: jonschz <jonschz@users.noreply.github.com>
2025-07-13 16:50:51 +02:00
jonschz
657720c825
Match Act3List::FUN_100720d0 (#1622) 2025-07-13 16:50:20 +02:00
jonschz
ac46537599
Interpret Act3List properties, minor fixes (#1619)
Co-authored-by: jonschz <jonschz@users.noreply.github.com>
2025-07-12 17:05:29 +02:00
Fabian Neundorf
d9d9880d8b
Clear unknowns in LegoAnimNodeData (#1617) 2025-07-11 17:11:12 -07:00
Fabian Neundorf
a34c293177
Name Disable function in LegoOmni and misc (#1616) 2025-07-11 17:10:36 -07:00
Fabian Neundorf
6497cb42b7
Clear unknowns in Matrix (#1615) 2025-07-10 18:58:53 -07:00
MS
c784fc32f1
Move g_skeletonKickPhases to .data (#1614) 2025-07-10 00:29:22 -04:00
Fabian Neundorf
f0f771f3f4
Clear global unknowns in LegoROI (#1611) 2025-07-09 21:28:59 -07:00
MS
4ebc5b453f
Improve match for Act3Ammo::Animate (#1612)
* Improve Act3Ammo

* Early return
2025-07-09 14:09:49 -04:00
Fabian Neundorf
5d3b6884e0
Clear unknowns in legoutils.h (#1610) 2025-07-08 07:26:32 -07:00
Fabian Neundorf
c7fda26cf4
Clear unknowns in Infocenter and InfocenterMapEntry (#1609) 2025-07-08 02:35:21 +02:00
Fabian Neundorf
8ffe7b776a
Clear unknowns in LegoControlManager (#1607) 2025-07-05 18:23:00 -07:00
Fabian Neundorf
d3aecadb07
Clear unknown in LegoModelPresenter (#1608) 2025-07-05 16:55:59 -07:00
Fabian Neundorf
5544640b22
Clear unknowns in MxControlPresenter (#1606) 2025-07-04 21:53:50 +02:00
MasterTimeThief
df3d144ed9
Renamed more functions and variables in Car Build sections (#1605)
* Renamed variables and functions related to the Car Build sections

* Car Build variable renaming - fixed issues and added enum `ShelfState`

* Fixed some spacing in `legocarbuildpresenter.h`

* Fixed tab spacing

* Changed `m_shelfState` back to `MxU16`

* Cleared up `InitBuildPlatform`

* Fixed comments

* Renamed more functions and variables in Car Build sections

* Named `SelectPartFromMousePosition`

* Updated spacing formatting in `LegoCarBuild`
2025-07-04 02:23:07 +02:00
Fabian Neundorf
16c76c96f2
Clear time started unknown in MxDSAction (#1604)
This should not be confused with `GetStartTime()`, as that represents the time offset from the SI file.
2025-07-03 23:56:48 +02:00
Anders Jenbo
44d1ad13fe
Set dwDDFX using flag (#1603) 2025-07-03 21:57:47 +02:00
Christian Semmler
4d8ba1986e
Fix writing default texture (#1602) 2025-07-03 02:07:16 +02:00
Christian Semmler
89fe7fa924
Fix wrong notification type in LegoRace::Notify (#1601) 2025-07-02 22:43:57 +02:00
Fabian Neundorf
40ec911811
Clear unknown in MxWavePresenter (#1600) 2025-07-02 21:09:25 +02:00
Fabian Neundorf
805c57b6aa
Clear unknowns in ViewLOD (#1599) 2025-07-02 02:02:03 +02:00
Fabian Neundorf
f825b053ff
Clear unknown in mxutilities.h (#1598)
Also change the parameter name to mask as it better represents the
usage.
2025-07-01 00:29:23 +02:00
Korbo
f0df3cd0ef
Clear a few unknowns in act 3 (#1597)
* Clear a few unknowns in act 3

* fix build error

* fix other build error

* requested changes
2025-06-30 12:20:53 -07:00
Christian Semmler
aa825aeecf
Add macro for switchable building index (#1596) 2025-06-29 17:55:34 +02:00
Fabian Neundorf
0982038453
Clear unknown in Hospital (#1595) 2025-06-28 15:38:48 -07:00
Fabian Neundorf
9dcc701fcb
Clear unknowns in GetSoundId (#1594) 2025-06-28 20:32:09 +02:00
Fabian Neundorf
89539a64f1
Clear unknown 0x10 in LegoEntity (#1593)
The naming is a bit weird, as only one bit is used so there are no other usages of this value.
2025-06-28 07:28:13 -07:00
Korbo
16a94c725c
Names for race related or adjacent functions and variables (#1592)
* Names for race related or adjacent functions and variables

* fix formatting

* fix formatting
2025-06-28 01:08:45 +02:00
Fabian Neundorf
056064f9d4
Clear unknown in LegoLOD (#1590)
The function does mostly the same as `SetTextureInfo` but does not
explicitly set the color as well.
2025-06-26 22:35:04 +02:00
Fabian Neundorf
b66d1e2f64
Clear unknowns in Ambulance and AmbulanceMissionState (#1588) 2025-06-26 20:31:30 +02:00
Fabian Neundorf
8498c69af1
Clear unknowns in LegoPlantManager (#1587) 2025-06-24 22:38:08 +02:00
Fabian Neundorf
7f10f7ae14
Clear unknown in ModelDbModel (#1586) 2025-06-23 14:34:02 -07:00
jonschz
edae5f58ec
Remove getters/setters that (likely) don't exist (#1583)
Co-authored-by: jonschz <jonschz@users.noreply.github.com>
2025-06-23 20:58:16 +02:00
MS
1701117e6f
Improve MeshBuilderImpl::CreateMesh (#1584)
* CreateMesh

* Effective match for Clone()
2025-06-23 10:24:13 -04:00
Christian Semmler
8195d2b251
Update legogamestate.cpp (#1582) 2025-06-22 18:48:09 +02:00
Christian Semmler
0a50915312
Fix implicit signed char-ness (#1581) 2025-06-22 17:55:36 +02:00
Fabian Neundorf
2595537c4c
Clear unknowns in LegoAnimActorEntry and LegoAnimKey (#1580) 2025-06-22 05:34:29 -07:00
jonschz
16db496832
Match LegoGameState::History::WriteScoreHistory(), clear unknowns (#1576)
---------

Co-authored-by: jonschz <jonschz@users.noreply.github.com>
2025-06-22 08:22:25 +02:00
Fabian Neundorf
e3fc6fd135
Use enum from LegoActor to map between string and id (#1577) 2025-06-21 15:32:30 -07:00
jonschz
f64af166c8
Add BETA10 addresses for LegoROI and others (#1569)
---------

Co-authored-by: jonschz <jonschz@users.noreply.github.com>
2025-06-21 07:52:24 +02:00
Florian Kaiser
72eb194424
Clear unknowns in LegoAnimPresenter and related classes (#1565)
* Clear unknowns in `LegoAnimPresenter` and related classes

* Update LEGO1/lego/legoomni/include/legoanimpresenter.h

---------

Co-authored-by: Christian Semmler <mail@csemmler.com>
2025-06-21 01:24:32 +02:00
Fabian Neundorf
f9e34c46e3
Clear unknowns in PizzeriaState, Pizza and PizzaMissionState (#1574) 2025-06-20 00:38:31 +02:00
Fabian Neundorf
6159d23cde
Clear unknowns in Radio and RadioState (#1573) 2025-06-19 23:52:02 +02:00
Fabian Neundorf
cf32607933
Clear unknown in ViewROI and ViewManager (#1571) 2025-06-18 07:06:43 -07:00
Christian Semmler
f48e947552
BETA only assertion in Act3Ammo::Create (#1568) 2025-06-17 19:33:14 +02:00
Fabian Neundorf
0b46acab54
Name m_unk0x21 as GetUseAlias in LegoMesh (#1567) 2025-06-17 18:42:59 +02:00
Fabian Neundorf
fd3f08f4c4
Clear unknowns in LegoBuildingInfo and LegoBuildingManager (#1566)
* Clear unknowns in `LegoBuildingInfo` and `LegoBuildingManager`

* Name remaining unknown in `LegoBuildingManager`
2025-06-16 23:08:17 +02:00
Fabian Neundorf
16ccb0e06e
Name locations after exiting buildings/vehicles (#1564)
* Hospital
* Infocenter
* Garage
* Police
* Jetski Build
* Racecar Build
* Any vehicle
2025-06-15 19:31:19 +02:00
Fabian Neundorf
aeac9f787e
Gasstation (#1560)
* Clear unknowns in `GasStation` and `GasStationState`

* Make global variable in gasstation unique

* Apply same name to global variable in hospital.cpp
2025-06-15 08:48:54 -07:00
Fabian Neundorf
26978f5484
Name LegoLOD::FUN_100aae20 (#1562) 2025-06-14 19:56:46 +02:00
Christian Semmler
e321385803
BETA matches in ViewManager (#1559)
* BETA matches

* Fix

* Fix `ViewManager::Update`
2025-06-13 04:14:28 +02:00
Fabian Neundorf
7b619d5544
Clear unknowns in LegoPlantManager (#1557) 2025-06-12 09:33:32 -07:00
jonschz
596ebde9d3
Add BETA10 assertions in LegoPathController (#1555)
* Add BETA10 assertions in LegoPathController

* formatting

---------

Co-authored-by: jonschz <jonschz@users.noreply.github.com>
2025-06-12 08:52:56 +02:00
MasterTimeThief
9aa8dbfc46
Clear unknowns in 'LegoCarBuild' and 'LegoCarBuildPresenter' (#1542)
* Renamed variables and functions related to the Car Build sections

* Car Build variable renaming - fixed issues and added enum `ShelfState`

* Fixed some spacing in `legocarbuildpresenter.h`

* Fixed tab spacing

* Changed `m_shelfState` back to `MxU16`

* Cleared up `InitBuildPlatform`

* Fixed comments
2025-06-11 23:37:50 +02:00
Fabian Neundorf
3b3fe276c4
Clear unknowns in LegoPhoneme (#1556) 2025-06-11 23:29:23 +02:00
Anonymous Maarten
bc481cc1c5
assert(0) in LegoCarRaceActor::VTable0x1c is beta10-only (#1553) 2025-06-11 03:17:24 +02:00
Fabian Neundorf
99ff92e49e
Use enum for states in PoliceState (#1552) 2025-06-10 16:07:10 -07:00
Fabian Neundorf
180d4949da
Clear unknowns in PoliceState (#1551) 2025-06-10 11:51:21 -07:00
Christian Semmler
8cdc8fbc05
Name LegoAnimationManager::m_unk0x41c (#1550) 2025-06-10 01:17:34 +02:00
MS
f334eae667
Fix #1548 (#1549) 2025-06-08 21:38:36 -04:00
Fabian Neundorf
82f1ce8814
Clear unknowns/numbers in Hospital and HospitalState (#1545)
* Define state variables in `HospitalState`

* Cleared unknown for flashing leds in `Hospital`

* Misc name changes in `Hospital`

* Name states in `Hospital`
2025-06-08 15:57:38 -07:00
Florian Kaiser
36c1093c88
Clear unknowns in LegoPathBoundary, LegoWEEdge, LegoWEGEdge and LegoPathController (#1546) 2025-06-08 11:04:58 -07:00
Florian Kaiser
06af7d25c6
Rename g_wdbOffset to g_wdbSkipGlobalPartsOffset for clarity (#1547) 2025-06-08 08:04:06 -07:00
Fabian Neundorf
7471852e9d
Named unknown function in LegoTextureInfo (#1544) 2025-06-07 18:04:55 +02:00
Christian Semmler
d714bf62f1
Improve LegoPathActor::VTable0x84 BETA match (#1543) 2025-06-06 23:22:46 +02:00
Fabian Neundorf
ac4d3b2490
Name for bounding box in ROI (#1541)
* Name for bounding box in ROI

* Use snake_case for member
2025-06-06 11:47:45 -07:00
Fabian Neundorf
9134dd791c
Name boolean field in Mesh (#1540) 2025-06-04 23:30:06 +02:00
Fabian Neundorf
d272054d5a
Clear unknowns in legocharactermanager (#1539) 2025-06-04 23:29:41 +02:00
Fabian Neundorf
d7d3a47cd2
Add names to LegoActorInfo.Part (#1538)
Each part consists of two "blocks" where every block has a list of
indices which reference into a list of names and the actual index used
for the list of indices.

By doing that, it is possible to reuse the list of name for every actor
and instead have a "sublist" through the indices list.
2025-06-03 18:11:01 -07:00
Fabian Neundorf
b4fb9f3a15
Better name for LegoActorLOD's flags (#1537) 2025-06-02 14:21:12 -07:00
Christian Semmler
f48dd8c912
Update legogamestate.cpp (#1535) 2025-06-01 18:46:14 +02:00
Anonymous Maarten
ac971f8c15
Assertion in MxTransitionManager::StartTransition is beta10-only (#1534)
This fixes an assertion error when:
1. Start the game
2  Skip intro (probably optional)
3. Turn left to the elevator room
4. Enter the elevator
5. Press the (I) button
2025-05-31 02:33:28 +02:00
Anonymous Maarten
941bc6ffa9
Fix UBSAN entering the petrol station car building minigame (#1533) 2025-05-31 02:19:11 +02:00
Anonymous Maarten
e813a12a4a
Fix notification/presenter casts (#1532)
* LegoCarBuild: cast c_notificationType0 to MxNotificationParam

* MxBackgroundAuioManager gets a MxWavePresenter
2025-05-30 21:43:33 +02:00
Fabian Neundorf
d0f4725f0f
Fill in unknown color string descriptions (#1531) 2025-05-30 21:12:49 +02:00
Christian Semmler
168bd4b26c
Fix LegoTreeNode* construction (#1530)
* Fix LegoTreeNode* construction

* Fix
2025-05-29 23:41:57 +02:00
Anders Jenbo
211d409992
Apply RAND_MAX to legoanimationmanager.cpp (#1528) 2025-05-29 06:52:15 -07:00
Anders Jenbo
6e0b580b86
Correct delete[] in legocarbuildpresenter.cpp (#1529) 2025-05-29 06:51:42 -07:00
Anonymous Maarten
30ae89f483
LegoMeterPresenter: use array deleter + BETA10-only assertion (#1527)
* LegoMeterPresenter: use array deleter

(cherry picked from commit 0897f75c7c)

* assert in LegoCarBUild::InitPresenter is BETA10-only

(cherry picked from commit 1a41b62f6f)
2025-05-28 20:25:05 -07:00
MS
5646d017f1
RendererImpl, CameraImpl, LightImpl (#1525) 2025-05-28 22:04:01 -04:00
Anonymous Maarten
45890eec94
legoanimationmanager: use delete[] (#1526) 2025-05-28 18:28:30 -07:00
jonschz
b7090bd838
Match LegoActor and LegoPathActor in BETA10 (#1524)
* Match `LegoActor` in BETA10

* Cleanup

---------

Co-authored-by: jonschz <jonschz@users.noreply.github.com>
2025-05-27 22:04:01 +02:00
jonschz
4186bae786
Match Helicopter::FUN_100042a0 (#1523)
* Match `Helicopter::FUN_100042a0`

* Add comment

---------

Co-authored-by: jonschz <jonschz@users.noreply.github.com>
2025-05-26 23:33:52 +02:00
MS
b28fcae005
Match TextureImpl functions (#1521)
* TextureImpl functions

* TglD3DRMIMAGE functions
2025-05-26 18:46:22 +02:00
Christian Semmler
04b669cf96
Fix type cast in MxControlPresenter::FUN_10044270 (#1522) 2025-05-26 18:45:06 +02:00
jonschz
f7744f5550
Fix ambiguous matches in BETA10 (#1520)
* Fix ambiguous matches in BETA10

* Add more functions, fix one LINE annotation

* Fix LEGO1 matches

---------

Co-authored-by: jonschz <jonschz@users.noreply.github.com>
2025-05-26 07:25:47 +02:00
MS
5ad885f958
TglImpl::DeviceImpl functions (#1519) 2025-05-25 11:37:16 -04:00
Florian Kaiser
804632b13f
Refactor LegoUnknown100db7f4 to LegoOrientedEdge (#1515)
* Refactor `LegoUnknown100db7f4` to `LegoOrientedEdge`

* Update LEGO1/lego/sources/geom/legoorientededge.h

* Update legopathcontroller.h

---------

Co-authored-by: Christian Semmler <mail@csemmler.com>
2025-05-24 23:09:24 -07:00
jonschz
8e54a20d7d
Match DecodeSS2 (#1476)
---------

Co-authored-by: jonschz <jonschz@users.noreply.github.com>
2025-05-25 07:59:58 +02:00
Christian Semmler
a860e76dba
Match LegoOmni::GetWorldId (#1517) 2025-05-24 17:12:07 +02:00
Florian Kaiser
90b5c27a8b
Clear unknowns in MxBackgroundAudioManager (#1516)
* Clear unknowns in `MxBackgroundAudioManager`

* Apply suggestions from code review

---------

Co-authored-by: Christian Semmler <mail@csemmler.com>
2025-05-24 06:49:43 -07:00
MS
4e49712391
Match Tgl MeshImpl and GroupImpl functions (#1514) 2025-05-23 12:27:41 -04:00
Erik Schulze
eb1177b409
rename functions and parameters in OrientableROI (#1512) 2025-05-21 20:13:28 -07:00
Anders Jenbo
5c67c26c3f
Fix MxHashTableNode constructor (#1511) 2025-05-20 20:42:42 +02:00
Anonymous Maarten
40a21867e8
Document buttonId in RegistrationBook (#1510) 2025-05-19 18:05:35 -07:00
Anonymous Maarten
0b9c1756c7
Fix inclusion guards of 3 files (#1509)
* Fix inclusion guards of 3 files

* Apply suggestions from code review

Co-authored-by: Christian Semmler <mail@csemmler.com>

---------

Co-authored-by: Christian Semmler <mail@csemmler.com>
2025-05-20 02:15:30 +02:00
Erik Schulze
d67318e78b
propagate name changes from commit fce97ea (#1508)
* propagate name changes from commit fce97ea

* remove dependency on omni types

* rename parameter too
2025-05-19 21:25:52 +02:00
Erik Schulze
7b34eea690
Use SUCCESS and FAILURE in MxPalette::SetSkyColor (#1506) 2025-05-18 16:36:25 -07:00
Anonymous Maarten
2915aa014f
Use sizeof(type) instead of sizeof(variableName) when (de)serializing data (#1505)
* Use sizeof(type) instead of sizeof(variableName) when (de)serializing data

* Less usage of sizeof(variableName) while (de)serializing
2025-05-18 22:56:28 +02:00