isledecomp/isle
1
0
Fork 0
mirror of https://github.com/isledecomp/isle.git synced 2026-01-27 18:21:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Better fix for MxRegionListCursor

Browse Source
This commit is contained in:
disinvite 2023-12-07 14:08:01 -05:00
parent 5e68e038f4
commit bd74959002
1 changed files with 4 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
LEGO1/mxregionlist.h
View File

@ -29,28 +29,15 @@ class MxRegionList : public MxPtrList<MxRegionTopBottom> {
// VTABLE: LEGO1 0x100dcba0 // VTABLE: LEGO1 0x100dcba0
// class MxListCursor<MxRegionTopBottom *> // class MxListCursor<MxRegionTopBottom *>
// TODO: MxRegionListCursor should probably extend MxPtrListCursor. Doing this has // TODO: The initialize list param type should be MxRegionList, but doing that
// drastically reduced the match percentage for MxRegion::vtable18, so we will replicate // drastically reduced the match percentage for MxRegion::vtable18.
// the previous cursor hierarchy with this dummy class for now. // It also works with MxPtrList, so we'll do that until we figure this out.
template <class T>
class _ListCursorDummy : public MxListCursor<T> {
public:
_ListCursorDummy(MxList<T>* p_list) : MxListCursor<T>(p_list){};
};
// VTABLE: LEGO1 0x100dcb88 // VTABLE: LEGO1 0x100dcb88
class MxRegionListCursor : public _ListCursorDummy<MxRegionTopBottom*> {
public:
MxRegionListCursor(MxList<MxRegionTopBottom*>* p_list) : _ListCursorDummy<MxRegionTopBottom*>(p_list){};
};
/*
class MxRegionListCursor : public MxPtrListCursor<MxRegionTopBottom> { class MxRegionListCursor : public MxPtrListCursor<MxRegionTopBottom> {
public: public:
MxRegionListCursor(MxRegionList* p_list) : MxPtrListCursor<MxRegionTopBottom>(p_list){}; MxRegionListCursor(MxPtrList<MxRegionTopBottom>* p_list) : MxPtrListCursor<MxRegionTopBottom>(p_list){};
}; };
*/
// VTABLE: LEGO1 0x100dcc40 // VTABLE: LEGO1 0x100dcc40
// class MxCollection<MxRegionLeftRight *> // class MxCollection<MxRegionLeftRight *>