From bd74959002331bc538b9480bf5e2fc40e2489217 Mon Sep 17 00:00:00 2001
From: disinvite <disinvite@users.noreply.github.com>
Date: Thu, 7 Dec 2023 14:08:01 -0500
Subject: [PATCH] Better fix for MxRegionListCursor

---
 LEGO1/mxregionlist.h | 21 ++++-----------------
 1 file changed, 4 insertions(+), 17 deletions(-)

diff --git a/LEGO1/mxregionlist.h b/LEGO1/mxregionlist.h
index a308ff4b..2938e38b 100644
--- a/LEGO1/mxregionlist.h
+++ b/LEGO1/mxregionlist.h
@@ -29,28 +29,15 @@ class MxRegionList : public MxPtrList<MxRegionTopBottom> {
 // VTABLE: LEGO1 0x100dcba0
 // class MxListCursor<MxRegionTopBottom *>
 
-// TODO: MxRegionListCursor should probably extend MxPtrListCursor. Doing this has
-// drastically reduced the match percentage for MxRegion::vtable18, so we will replicate
-// the previous cursor hierarchy with this dummy class for now.
-
-template <class T>
-class _ListCursorDummy : public MxListCursor<T> {
-public:
-	_ListCursorDummy(MxList<T>* p_list) : MxListCursor<T>(p_list){};
-};
+// TODO: The initialize list param type should be MxRegionList, but doing that
+// drastically reduced the match percentage for MxRegion::vtable18.
+// It also works with MxPtrList, so we'll do that until we figure this out.
 
 // VTABLE: LEGO1 0x100dcb88
-class MxRegionListCursor : public _ListCursorDummy<MxRegionTopBottom*> {
-public:
-	MxRegionListCursor(MxList<MxRegionTopBottom*>* p_list) : _ListCursorDummy<MxRegionTopBottom*>(p_list){};
-};
-
-/*
 class MxRegionListCursor : public MxPtrListCursor<MxRegionTopBottom> {
 public:
-  MxRegionListCursor(MxRegionList* p_list) : MxPtrListCursor<MxRegionTopBottom>(p_list){};
+	MxRegionListCursor(MxPtrList<MxRegionTopBottom>* p_list) : MxPtrListCursor<MxRegionTopBottom>(p_list){};
 };
-*/
 
 // VTABLE: LEGO1 0x100dcc40
 // class MxCollection<MxRegionLeftRight *>