isledecomp/isle
1
0
Fork 0
mirror of https://github.com/isledecomp/isle.git synced 2026-01-26 01:31:20 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Change code duplication comments

Browse Source
This commit is contained in:
jonschz 2024-08-03 06:36:52 +02:00
parent e294c86f65
commit 162e8dbd65
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
LEGO1/lego/legoomni/src/race/legoraceactor.cpp
View File

@ -47,9 +47,7 @@ MxS32 LegoRaceActor::VTable0x68(Vector3& p_v1, Vector3& p_v2, Vector3& p_v3)
// FUNCTION: BETA10 0x100c9c93 // FUNCTION: BETA10 0x100c9c93
MxU32 LegoRaceActor::VTable0x90(float p_float, Matrix4& p_transform) MxU32 LegoRaceActor::VTable0x90(float p_float, Matrix4& p_transform)
{ {
// TODO: Note the similarity to LegoExtraActor::VTable0x90. // Note: Code duplication with LegoExtraActor::VTable0x90
// Code duplication or is there something deeper going on?
switch (m_state) { switch (m_state) {
case 0: case 0:
case 1: case 1:

3
LEGO1/lego/legoomni/src/race/legoracers.cpp
View File

@ -405,9 +405,8 @@ void LegoRaceCar::VTable0x70(float p_float)
// FUNCTION: BETA10 0x100cbb84 // FUNCTION: BETA10 0x100cbb84
MxResult LegoRaceCar::VTable0x94(LegoPathActor* p_actor, MxBool p_bool) MxResult LegoRaceCar::VTable0x94(LegoPathActor* p_actor, MxBool p_bool)
{ {
// Note: Code duplication with LegoRaceActor::VTable0x94
if (!p_actor->GetUserNavFlag()) { if (!p_actor->GetUserNavFlag()) {
// TODO: Note how this code is almost, but not quite identical to LegoRaceActor::VTable0x94.
// Maybe there is some code reuse here? The use of different globals is notable.
if (p_actor->GetState()) { if (p_actor->GetState()) {
return FAILURE; return FAILURE;
} }