isledecomp/isle-portable
1
0
Fork 0
mirror of https://github.com/isledecomp/isle-portable.git synced 2026-01-15 03:51:14 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove dynamic_cast (#139)

Browse Source
This commit is contained in:
Christian Semmler 2025-05-20 16:29:51 -07:00 committed by GitHub
parent 9d06cd9e53
commit 9e3e039c3f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
LEGO1/lego/legoomni/src/paths/legopathboundary.cpp
View File

@ -356,14 +356,7 @@ MxU32 LegoPathBoundary::FUN_10057fe0(LegoAnimPresenter* p_presenter)
return 0;
}
// TODO: This only seems to match if the type is not the same as the type of the
// key value of the set. Figure out which type the set (or parameter) actually uses.
// Also see call to .find in LegoPathController::FUN_10046050
if (auto* locomotionPresenter = dynamic_cast<LegoLocomotionAnimPresenter*>(p_presenter)) {
m_presenters.insert(locomotionPresenter);
return 1;
}
SDL_LogError(SDL_LOG_CATEGORY_APPLICATION, "Invalid locomotion");
m_presenters.insert(p_presenter);
return 0;
}
@ -372,17 +365,8 @@ MxU32 LegoPathBoundary::FUN_10057fe0(LegoAnimPresenter* p_presenter)
MxU32 LegoPathBoundary::FUN_100586e0(LegoAnimPresenter* p_presenter)
{
if (p_presenter != NULL) {
// TODO: This only seems to match if the type is not the same as the type of the
// key value of the set. Figure out which type the set (or parameter) actually uses.
// Also see call to .find in LegoPathController::FUN_10046050
auto* locomotionPresenter = dynamic_cast<LegoLocomotionAnimPresenter*>(p_presenter);
if (!locomotionPresenter) {
SDL_LogError(SDL_LOG_CATEGORY_APPLICATION, "Invalid locomotion");
return 0;
}
auto it = m_presenters.find(locomotionPresenter);
if (it != m_presenters.end()) {
m_presenters.erase(it);
if (m_presenters.find(p_presenter) != m_presenters.end()) {
m_presenters.erase(p_presenter);
return 1;
}
}