isledecomp/isle-portable
1
0
Fork 0
mirror of https://github.com/isledecomp/isle-portable.git synced 2026-05-02 02:23:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix: stop previous click animation before starting a new one

Browse Source 
Rapid customize clicks would orphan running click animations because
SetClickAnimObjectId overwrote the tracked ID without stopping the old
animation first. When movement later called StopClickAnimation, only
the last animation was stopped, leaving earlier ones driving the ROI
transform and causing the player model to stay behind while the camera
moved forward.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Christian Semmler 2026-03-10 19:45:20 -07:00
parent 1714142b6f
commit 9145a23ffe
No known key found for this signature in database
GPG Key ID: 086DAA1360BEEE5C
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/src/multiplayer/networkmanager.cpp
View File

@ -700,6 +700,7 @@ void NetworkManager::HandleCustomize(const CustomizeMsg& p_msg)
p_msg.changeType == CHANGE_MOOD
);
if (!it->second->IsMoving() && !it->second->IsInMultiPartEmote()) {
it->second->StopClickAnimation();
MxU32 clickAnimId =
CharacterCustomizer::PlayClickAnimation(it->second->GetROI(), it->second->GetCustomizeState());
it->second->SetClickAnimObjectId(clickAnimId);
@ -734,6 +735,7 @@ void NetworkManager::HandleCustomize(const CustomizeMsg& p_msg)
// Only play click animation in 3rd person (not visible in 1st person or multi-part emote)
if (m_thirdPersonCamera.GetDisplayROI() && !m_thirdPersonCamera.IsInVehicle() &&
!m_thirdPersonCamera.IsInMultiPartEmote()) {
m_thirdPersonCamera.StopClickAnimation();
MxU32 clickAnimId = CharacterCustomizer::PlayClickAnimation(
m_thirdPersonCamera.GetDisplayROI(),
m_thirdPersonCamera.GetCustomizeState()