isledecomp/isle-portable
1
0
Fork 0
mirror of https://github.com/isledecomp/isle-portable.git synced 2026-02-03 12:31:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

TextureLoader: unlock surface on failure paths

Browse Source
This commit is contained in:
Anonymous Maarten 2026-01-31 03:56:59 +01:00
parent a3122cd209
commit 5f32188db3
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/src/textureloader.cpp
View File

@ -64,6 +64,7 @@ bool TextureLoader::PatchTexture(LegoTextureInfo* p_textureInfo)
if (details->bits_per_pixel == 8) { if (details->bits_per_pixel == 8) {
SDL_Palette* sdlPalette = SDL_GetSurfacePalette(surface); SDL_Palette* sdlPalette = SDL_GetSurfacePalette(surface);
if (!sdlPalette) { if (!sdlPalette) {
p_textureInfo->m_surface->Unlock(desc.lpSurface);
SDL_DestroySurface(surface); SDL_DestroySurface(surface);
return false; return false;
} }
@ -78,6 +79,7 @@ bool TextureLoader::PatchTexture(LegoTextureInfo* p_textureInfo)
LPDIRECTDRAWPALETTE ddPalette = nullptr; LPDIRECTDRAWPALETTE ddPalette = nullptr;
if (pDirectDraw->CreatePalette(DDPCAPS_8BIT | DDPCAPS_ALLOW256, entries, &ddPalette, NULL) != DD_OK) { if (pDirectDraw->CreatePalette(DDPCAPS_8BIT | DDPCAPS_ALLOW256, entries, &ddPalette, NULL) != DD_OK) {
p_textureInfo->m_surface->Unlock(desc.lpSurface);
SDL_DestroySurface(surface); SDL_DestroySurface(surface);
return false; return false;
} }