isledecomp/isle-portable
1
0
Fork 0
mirror of https://github.com/isledecomp/isle-portable.git synced 2026-02-03 12:31:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Anders Jenbo <anders@jenbo.dk>
This commit is contained in:
Joshua Peisach 2025-06-16 14:51:22 -04:00
parent b1dfa61c38
commit 3e5d447f9b
No known key found for this signature in database
GPG Key ID: 41C3D4189AFEDB5A
4 changed files with 7 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
CMakeLists.txt
View File

@ -643,9 +643,7 @@ endif()
set(CPACK_PACKAGE_DIRECTORY "dist") set(CPACK_PACKAGE_DIRECTORY "dist")
set(CPACK_PACKAGE_FILE_NAME "isle-${PROJECT_VERSION}-${ISLE_PACKAGE_NAME}-${CMAKE_SYSTEM_PROCESSOR}") set(CPACK_PACKAGE_FILE_NAME "isle-${PROJECT_VERSION}-${ISLE_PACKAGE_NAME}-${CMAKE_SYSTEM_PROCESSOR}")
if(MSVC) if(NINTENDO_3DS)
set(CPACK_GENERATOR ZIP)
elseif(NINTENDO_3DS)
include(Tools3DS) include(Tools3DS)
set(APP_TITLE "LEGO Island") set(APP_TITLE "LEGO Island")
set(APP_DESCRIPTION "LEGO Island port for 3DS") set(APP_DESCRIPTION "LEGO Island port for 3DS")
@ -654,6 +652,10 @@ elseif(NINTENDO_3DS)
set(APP_VERSION ${PROJECT_VERSION}) set(APP_VERSION ${PROJECT_VERSION})
add_3dsx_target(isle) add_3dsx_target(isle)
endif()
if(MSVC)
set(CPACK_GENERATOR ZIP)
else() else()
set(CPACK_GENERATOR TGZ) set(CPACK_GENERATOR TGZ)
endif() endif()

6
LEGO1/tgl/d3drm/mesh.cpp
View File

@ -102,11 +102,7 @@ inline Result MeshDeepClone(MeshImpl::MeshData* pSource, MeshImpl::MeshData*& rp
assert(Succeeded(result)); assert(Succeeded(result));
#if defined(__3DS__) DWORD* faceBuffer = new DWORD[dataSize];
unsigned long* faceBuffer = new unsigned long[dataSize];
#else
unsigned int* faceBuffer = new unsigned int[dataSize];
#endif
result = result =
ResultVal(pSource->groupMesh->GetGroup(pSource->groupIndex, &vcount, &fcount, &vperface, &dataSize, faceBuffer) ResultVal(pSource->groupMesh->GetGroup(pSource->groupIndex, &vcount, &fcount, &vperface, &dataSize, faceBuffer)
); );

6
LEGO1/tgl/d3drm/meshbuilder.cpp
View File

@ -63,11 +63,7 @@ inline Result CreateMesh(
int count = faceCount * 3; int count = faceCount * 3;
int index = 0; int index = 0;
#if defined(__3DS__) DWORD* fData = new DWORD[count];
unsigned long* fData = new unsigned long[count];
#else
unsigned int* fData = new unsigned int[count];
#endif
D3DRMVERTEX* vertices = new D3DRMVERTEX[vertexCount]; D3DRMVERTEX* vertices = new D3DRMVERTEX[vertexCount];
memset(vertices, 0, sizeof(*vertices) * vertexCount); memset(vertices, 0, sizeof(*vertices) * vertexCount);

1
miniwin/src/d3drm/backends/sdl3gpu/renderer.cpp
View File

@ -192,7 +192,6 @@ Direct3DRMRenderer* Direct3DRMSDL3GPURenderer::Create(DWORD width, DWORD height)
)}; )};
if (!device.ptr) { if (!device.ptr) {
SDL_LogError(LOG_CATEGORY_MINIWIN, "SDL_CreateGPUDevice failed (%s)", SDL_GetError()); SDL_LogError(LOG_CATEGORY_MINIWIN, "SDL_CreateGPUDevice failed (%s)", SDL_GetError());
SDL_Log("width: %d height: %d", width, height);
return nullptr; return nullptr;
} }