From e25289a02bfad068de1c9cbcf7dbc4d74c0da599 Mon Sep 17 00:00:00 2001 From: Fabian Neundorf Date: Tue, 13 Jan 2026 22:25:28 +0100 Subject: [PATCH] Clear unknowns in `LegoActionControlPresenter` --- .../include/legoactioncontrolpresenter.h | 8 ++++---- .../src/common/legoactioncontrolpresenter.cpp | 16 ++++++++-------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/LEGO1/lego/legoomni/include/legoactioncontrolpresenter.h b/LEGO1/lego/legoomni/include/legoactioncontrolpresenter.h index 3b3193bf..ec142d22 100644 --- a/LEGO1/lego/legoomni/include/legoactioncontrolpresenter.h +++ b/LEGO1/lego/legoomni/include/legoactioncontrolpresenter.h @@ -10,7 +10,7 @@ // SIZE 0x68 class LegoActionControlPresenter : public MxMediaPresenter { public: - LegoActionControlPresenter() : m_unk0x50(Extra::ActionType::e_none) {} + LegoActionControlPresenter() : m_actionType(Extra::ActionType::e_none) {} ~LegoActionControlPresenter() override { Destroy(TRUE); } // vtable+0x00 // FUNCTION: BETA10 0x100a7840 @@ -40,9 +40,9 @@ class LegoActionControlPresenter : public MxMediaPresenter { virtual void Destroy(MxBool p_fromDestructor); // vtable+0x5c private: - Extra::ActionType m_unk0x50; // 0x50 - MxString m_unk0x54; // 0x54 - undefined4 m_unk0x64; // 0x64 + Extra::ActionType m_actionType; // 0x50 + MxString m_sourceName; // 0x54 + undefined4 m_streamId; // 0x64 }; // SYNTHETIC: LEGO1 0x1000d1d0 diff --git a/LEGO1/lego/legoomni/src/common/legoactioncontrolpresenter.cpp b/LEGO1/lego/legoomni/src/common/legoactioncontrolpresenter.cpp index 0e22d8de..266078ac 100644 --- a/LEGO1/lego/legoomni/src/common/legoactioncontrolpresenter.cpp +++ b/LEGO1/lego/legoomni/src/common/legoactioncontrolpresenter.cpp @@ -36,11 +36,11 @@ void LegoActionControlPresenter::ReadyTickle() void LegoActionControlPresenter::RepeatingTickle() { if (IsEnabled()) { - if (m_unk0x50 == 0) { + if (m_actionType == 0) { ParseExtra(); } - InvokeAction(m_unk0x50, MxAtomId(m_unk0x54.GetData(), e_lowerCase2), m_unk0x64, NULL); + InvokeAction(m_actionType, MxAtomId(m_sourceName.GetData(), e_lowerCase2), m_streamId, NULL); ProgressTickleState(e_done); } } @@ -84,15 +84,15 @@ void LegoActionControlPresenter::ParseExtra() char output[1024]; if (KeyValueStringParse(output, g_strACTION, extraCopy)) { - m_unk0x50 = MatchActionString(strtok(output, g_parseExtraTokens)); + m_actionType = MatchActionString(strtok(output, g_parseExtraTokens)); - if (m_unk0x50 != Extra::ActionType::e_exit) { + if (m_actionType != Extra::ActionType::e_exit) { MakeSourceName(extraCopy, strtok(NULL, g_parseExtraTokens)); - m_unk0x54 = extraCopy; - m_unk0x54.ToLowerCase(); - if (m_unk0x50 != Extra::ActionType::e_run) { - m_unk0x64 = atoi(strtok(NULL, g_parseExtraTokens)); + m_sourceName = extraCopy; + m_sourceName.ToLowerCase(); + if (m_actionType != Extra::ActionType::e_run) { + m_streamId = atoi(strtok(NULL, g_parseExtraTokens)); } } }