Address review comments

This commit is contained in:
jonschz 2024-09-03 22:14:27 +02:00
parent 2bfebc0793
commit bd4fc752e6
3 changed files with 4 additions and 6 deletions

View File

@ -74,14 +74,15 @@ class LegoCarBuild : public LegoWorld {
return "LegoCarBuild"; return "LegoCarBuild";
} }
MxLong Notify(MxParam& p_param) override; // vtable+0x04
MxResult Tickle() override; // vtable+0x08
// FUNCTION: LEGO1 0x10022950 // FUNCTION: LEGO1 0x10022950
MxBool IsA(const char* p_name) const override // vtable+0x10 MxBool IsA(const char* p_name) const override // vtable+0x10
{ {
return !strcmp(p_name, LegoCarBuild::ClassName()) || LegoWorld::IsA(p_name); return !strcmp(p_name, LegoCarBuild::ClassName()) || LegoWorld::IsA(p_name);
} }
MxLong Notify(MxParam& p_param) override; // vtable+0x04
MxResult Tickle() override; // vtable+0x08
MxResult Create(MxDSAction& p_dsAction) override; // vtable+0x18 MxResult Create(MxDSAction& p_dsAction) override; // vtable+0x18
void ReadyWorld() override; // vtable+0x50 void ReadyWorld() override; // vtable+0x50
MxBool VTable0x5c() override; // vtable+0x5c MxBool VTable0x5c() override; // vtable+0x5c

View File

@ -261,7 +261,6 @@ void LegoCarBuild::VTable0x74(MxFloat p_param1[3], MxFloat p_param2[3])
p_param2[0] = (fVar1 * local14[0] + local20[0]) - m_unk0x2a4[0]; p_param2[0] = (fVar1 * local14[0] + local20[0]) - m_unk0x2a4[0];
p_param2[1] = (fVar1 * local14[1] + local20[1]) - m_unk0x2a4[1]; p_param2[1] = (fVar1 * local14[1] + local20[1]) - m_unk0x2a4[1];
p_param2[2] = 0.0; p_param2[2] = 0.0;
return;
} }
// FUNCTION: LEGO1 0x10023570 // FUNCTION: LEGO1 0x10023570
@ -317,7 +316,6 @@ void LegoCarBuild::VTable0x80(MxFloat p_param1[2], MxFloat p_param2[2], MxFloat
// FUNCTION: BETA10 0x1006c18f // FUNCTION: BETA10 0x1006c18f
MxResult LegoCarBuild::Tickle() MxResult LegoCarBuild::Tickle()
{ {
if (!m_worldStarted) { if (!m_worldStarted) {
LegoWorld::Tickle(); LegoWorld::Tickle();
return SUCCESS; return SUCCESS;
@ -551,7 +549,6 @@ void LegoCarBuild::FUN_10025db0(const char* p_param1, undefined4 p_param2)
if (sVar3 != g_unk0x100f11cc) { if (sVar3 != g_unk0x100f11cc) {
TogglePresentersEnabled(); TogglePresentersEnabled();
g_unk0x100f11cc = sVar3; g_unk0x100f11cc = sVar3;
return;
} }
} }
else { else {

View File

@ -3,7 +3,6 @@
#include "3dmanager/lego3dmanager.h" #include "3dmanager/lego3dmanager.h"
#include "act2main_actions.h" #include "act2main_actions.h"
#include "act3_actions.h" #include "act3_actions.h"
#include "assert.h"
#include "carrace_actions.h" #include "carrace_actions.h"
#include "carracer_actions.h" #include "carracer_actions.h"
#include "copter_actions.h" #include "copter_actions.h"
@ -57,6 +56,7 @@
#include "scripts.h" #include "scripts.h"
#include "sndanim_actions.h" #include "sndanim_actions.h"
#include <assert.h>
#include <stdio.h> #include <stdio.h>
DECOMP_SIZE_ASSERT(LegoGameState::Username, 0x0e) DECOMP_SIZE_ASSERT(LegoGameState::Username, 0x0e)