isledecomp/isle
1
0
Fork 0
mirror of https://github.com/isledecomp/isle.git synced 2026-01-24 00:31:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improvements to documentation

Browse Source
This commit is contained in:
jonschz 2024-07-30 14:12:08 +02:00
parent 2bb89b42ff
commit bab464fb07
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/ghidra_scripts/lego_util/function_importer.py
View File

@ -215,7 +215,7 @@ def overwrite_ghidra_function(self, ghidra_function: Function):
"""Replace the function declaration in Ghidra by the one derived from C++.""" """Replace the function declaration in Ghidra by the one derived from C++."""
if ghidra_function.hasCustomVariableStorage(): if ghidra_function.hasCustomVariableStorage():
# Unfortunately, Ghidra has a bug where setting custom variable storage back to `False` # Unfortunately, calling `ghidra_function.setCustomVariableStorage(False)`
# leads to two `this` parameters. Therefore, we first need to remove all `this` parameters # leads to two `this` parameters. Therefore, we first need to remove all `this` parameters
# and then re-generate a new one # and then re-generate a new one
ghidra_function.replaceParameters( ghidra_function.replaceParameters(
@ -330,7 +330,7 @@ def _set_this_adjust(
ghidra_function: Function, ghidra_function: Function,
): ):
""" """
Then `this adjust` is non-zero, the pointer type of `this` needs to be replaced by an offset version. When `this adjust` is non-zero, the pointer type of `this` needs to be replaced by an offset version.
The offset can only be set on a typedef on the pointer. We also must enable custom storage so we can modify The offset can only be set on a typedef on the pointer. We also must enable custom storage so we can modify
the auto-generated `this` parameter. the auto-generated `this` parameter.
""" """