isledecomp/isle
1
0
Fork 0
mirror of https://github.com/isledecomp/isle.git synced 2026-01-28 10:41:15 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Add comment about buffer overrun

Browse Source
This commit is contained in:
Christian Semmler 2024-03-03 17:08:25 -05:00
parent 8748e26ab3
commit af3216b7b7
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
LEGO1/modeldb/modeldb.cpp
View File

@ -57,6 +57,8 @@ MxResult ModelDbPart::Read(FILE* p_file)
if (fread(&len, sizeof(len), 1, p_file) != 1) { if (fread(&len, sizeof(len), 1, p_file) != 1) {
return FAILURE; return FAILURE;
} }
// Critical bug: buffer overrun
if (fread(buff, len, 1, p_file) != 1) { if (fread(buff, len, 1, p_file) != 1) {
return FAILURE; return FAILURE;
} }