From a3013e7a875dea5b021495249b06a410de564d7f Mon Sep 17 00:00:00 2001 From: jonschz Date: Sun, 28 Jul 2024 20:01:49 +0200 Subject: [PATCH] Address review comments --- LEGO1/lego/legoomni/include/legoactor.h | 2 +- LEGO1/lego/legoomni/src/entity/legocarraceactor.cpp | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/LEGO1/lego/legoomni/include/legoactor.h b/LEGO1/lego/legoomni/include/legoactor.h index 548480b1..d5641b72 100644 --- a/LEGO1/lego/legoomni/include/legoactor.h +++ b/LEGO1/lego/legoomni/include/legoactor.h @@ -52,7 +52,7 @@ class LegoActor : public LegoEntity { virtual void VTable0x58(MxFloat p_unk0x70) { m_unk0x70 = p_unk0x70; } // vtable+0x58 // FUNCTION: LEGO1 0x10002cf0 - virtual MxFloat GetUnk0x70() { return m_unk0x70; } // vtable+0x5c + virtual MxFloat VTable0x5c() { return m_unk0x70; } // vtable+0x5c // FUNCTION: LEGO1 0x10002d00 virtual MxU8 GetActorId() { return m_actorId; } // vtable+0x60 diff --git a/LEGO1/lego/legoomni/src/entity/legocarraceactor.cpp b/LEGO1/lego/legoomni/src/entity/legocarraceactor.cpp index 0658d847..3dd009da 100644 --- a/LEGO1/lego/legoomni/src/entity/legocarraceactor.cpp +++ b/LEGO1/lego/legoomni/src/entity/legocarraceactor.cpp @@ -36,7 +36,7 @@ LegoCarRaceActor::LegoCarRaceActor() void LegoCarRaceActor::FUN_10080590(float p_float) { MxFloat maxSpeed = m_maxLinearVel; - Mx3DPointFloat destEdgeUnknownVector = Mx3DPointFloat(); + Mx3DPointFloat destEdgeUnknownVector; Mx3DPointFloat worldDirection = Mx3DPointFloat(m_roi->GetWorldDirection()); m_destEdge->FUN_1002ddc0(*m_boundary, destEdgeUnknownVector); @@ -49,7 +49,8 @@ void LegoCarRaceActor::FUN_10080590(float p_float) LegoPathActor* userActor = UserActor(); if (userActor) { - deltaUnk0x70 = m_unk0x70 - userActor->GetUnk0x70(); + // All known implementations of LegoPathActor->VTable0x5c() return LegoPathActor::m_unk0x70 + deltaUnk0x70 = m_unk0x70 - userActor->VTable0x5c(); } else { deltaUnk0x70 = 0;