isledecomp/isle
1
0
Fork 0
mirror of https://github.com/isledecomp/isle.git synced 2026-01-11 18:51:16 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Address review comment

Browse Source
This commit is contained in:
jonschz 2025-06-22 08:17:18 +02:00
parent c667dfcec0
commit 785c7dc65f
2 changed files with 10 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
LEGO1/lego/legoomni/include/legogamestate.h
View File

@ -152,7 +152,16 @@ class LegoGameState {
Username m_name; // 0x1c
MxS16 m_playerId; // 0x2a
ScoreItem& operator=(const ScoreItem& p_other);
ScoreItem& operator=(const ScoreItem& p_other)
{
// MSVC auto-generates an operator=, but LegoGameState::WriteScoreHistory() has a much better match
// with a manual implementation.
m_totalScore = p_other.m_totalScore;
memcpy(m_scores, p_other.m_scores, sizeof(m_scores));
m_name = p_other.m_name;
m_playerId = p_other.m_playerId;
return *this;
}
};
// SIZE 0x372

12
LEGO1/lego/legoomni/src/common/legogamestate.cpp
View File

@ -141,18 +141,6 @@ const char* g_strEnable = "enable";
// STRING: LEGO1 0x100f3bf4
const char* g_strDisable = "disable";
inline LegoGameState::ScoreItem& LegoGameState::ScoreItem::operator=(const ScoreItem& p_other)
{
// MSVC auto-generates an operator=, but LegoGameState::WriteScoreHistory() has a much better match
// with a manual implementation. Not sure if this function is supposed to go be in legogamestate.h
// instead of having an `inline` modifier.
m_totalScore = p_other.m_totalScore;
memcpy(m_scores, p_other.m_scores, sizeof(m_scores));
m_name = p_other.m_name;
m_playerId = p_other.m_playerId;
return *this;
}
// FUNCTION: LEGO1 0x10039550
LegoGameState::LegoGameState()
{