isledecomp/isle
1
0
Fork 0
mirror of https://github.com/isledecomp/isle.git synced 2026-02-03 13:41:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix savegame.ksy: backgroundcolor uses HSV, not RGB (#1738)
Some checks are pending
Analyze / ${{ matrix.who }} annotations (CONFIG) (push) Waiting to run
Details
Analyze / ${{ matrix.who }} annotations (ISLE) (push) Waiting to run
Details
Analyze / ${{ matrix.who }} annotations (LEGO1) (push) Waiting to run
Details
Build / Download original binaries (push) Waiting to run
Details
Build / Current ${{ matrix.toolchain.name }} (map[clang-tidy:true msys-env:mingw-w64-i686 msystem:mingw32 name:msys2 mingw32 shell:msys2 {0} werror:true]) (push) Waiting to run
Details
Build / Current ${{ matrix.toolchain.name }} (map[name:MSVC setup-cmake:true setup-msvc:true setup-ninja:true shell:sh]) (push) Waiting to run
Details
Build / MSVC 4.20 (push) Waiting to run
Details
Build / MSVC 4.20 (BETA10) (push) Waiting to run
Details
Build / Verify decomp (push) Blocked by required conditions
Details
Build / Upload artifacts (push) Blocked by required conditions
Details
Format / C++ (push) Waiting to run
Details
Naming / C++ (push) Waiting to run
Details

Browse Source 
The backgroundcolor and tempBackgroundColor variables store HSV values
(scaled 0-100), not RGB. The game converts to RGB using ConvertHSVToRGB().
This commit is contained in:
Christian Semmler 2026-02-01 12:43:41 -08:00 committed by GitHub
parent 56ed4d3339
commit 77bb4634b8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docs/savegame.ksy
View File

@ -101,7 +101,9 @@ types:
if: not is_end_marker if: not is_end_marker
doc: | doc: |
Variable value. For colors this is a color name like "lego red". Variable value. For colors this is a color name like "lego red".
For backgroundcolor this is "set R G B". For backgroundcolor and tempBackgroundColor this is "set H S V" where
H, S, V are HSV color values scaled 0-100 (not RGB). The game internally
converts to RGB using ConvertHSVToRGB().
For lightposition this is a number "1" or "2". For lightposition this is a number "1" or "2".
instances: instances:
is_end_marker: is_end_marker: