isledecomp/isle
1
0
Fork 0
mirror of https://github.com/isledecomp/isle.git synced 2026-01-20 14:51:15 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

improved MxPalette::operator==, will be 100% when MSVC feels like making it so

Browse Source
This commit is contained in:
ktkaufman03 2023-07-03 00:22:48 -04:00
parent e3658b84ed
commit 772980db17
No known key found for this signature in database
GPG Key ID: 1E1BF4F2F99E03BB
2 changed files with 12 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
LEGO1/mxpalette.cpp
View File

@ -100,23 +100,18 @@ void MxPalette::GetDefaultPalette(LPPALETTEENTRY p_entries)
}
// OFFSET: LEGO1 0x100bf340
MxBool MxPalette::operator==(MxPalette *p_palette)
MxBool MxPalette::operator==(MxPalette &other)
{
// FIXME: ok, idk what is happening here: trying memcpy in different ways showed 0.00% match. Here is literally what it does.
// My guess is that memcpy doesn't break its loop when something is incorrect, and this function is only intended to check
// the RGB and memcpy does everything? The paramater 'rhs' in ghidra suggests it was likely some memcmp. For now,
// this is literally down to instruction swap.
int i = 0;
PALETTEENTRY *our = this->m_entries;
PALETTEENTRY *their = p_palette->m_entries;
do {
if(our->peRed != their->peRed) return FALSE;
if(our->peGreen != their->peGreen) return FALSE;
if(our->peBlue != their->peBlue) return FALSE;
their += 1;
our += 1;
i += 1;
} while (i < 256);
int i;
for (i = 0; i < 256; i++)
{
if (this->m_entries[i].peRed != other.m_entries[i].peRed)
return FALSE;
if (this->m_entries[i].peGreen != other.m_entries[i].peGreen)
return FALSE;
if (this->m_entries[i].peBlue != other.m_entries[i].peBlue)
return FALSE;
}
return TRUE;
}

2
LEGO1/mxpalette.h
View File

@ -11,7 +11,7 @@
class MxPalette : public MxCore
{
public:
__declspec(dllexport) MxBool operator==(MxPalette *p_palette);
__declspec(dllexport) MxBool operator==(MxPalette &);
__declspec(dllexport) void Detach();
MxPalette();