isledecomp/isle
1
0
Fork 0
mirror of https://github.com/isledecomp/isle.git synced 2026-02-03 05:31:17 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improve jumps

Browse Source
This commit is contained in:
jonschz 2025-05-25 07:36:12 +02:00
parent d52af801a0
commit 7306d7a992
1 changed files with 40 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
LEGO1/omni/src/video/flic.cpp
View File

@ -379,43 +379,48 @@ void DecodeSS2(LPBITMAPINFOHEADER p_bitmapHeader, BYTE* p_pixelData, BYTE* p_dat
skip_lines: skip_lines:
// The layout in BETA10 strongly suggests that lots of `goto`s are used. // The layout in BETA10 strongly suggests that lots of `goto`s are used.
// LINE: LEGO1 0x100bdb05
// LINE: BETA10 0x1013e684 // LINE: BETA10 0x1013e684
row += token; row += token;
start_packet: start_packet:
do { do {
// LINE: LEGO1 0x100bdaef
// LINE: BETA10 0x1013e692 // LINE: BETA10 0x1013e692
token = *(short*) data; token = *(short*) data;
data += 2; data += 2;
// LINE: LEGO1 0x100bdafb
if (token >= 0) { if (token >= 0) {
goto column_loop; goto column_loop;
} }
// LINE: LEGO1 0x100bdb00
if ((unsigned short) token & 0x4000) { if ((unsigned short) token & 0x4000) {
goto skip_lines; goto skip_lines;
} }
// LINE: LEGO1 0x100bdb0a
WritePixel(p_bitmapHeader, p_pixelData, xmax, row, token); WritePixel(p_bitmapHeader, p_pixelData, xmax, row, token);
token = *(short*) data; token = *(short*) data;
data += 2; data += 2;
// LINE: LEGO1 0x100bdb2f
// LINE: BETA10 0x1013e6ef // LINE: BETA10 0x1013e6ef
if (!token) { if (!token) {
row--; row--;
if (--lines > 0) { if (--lines > 0) {
goto start_packet; goto start_packet;
} }
break; return;
} }
else {
// TODO: Something is still slightly incorrect here - orig has two `jmp`s, recomp only has one
column_loop: column_loop:
// LINE: LEGO1 0x100bdb49
// LINE: BETA10 0x1013e71e // LINE: BETA10 0x1013e71e
short column = xofs; short column = xofs;
column_loop_inner: column_loop_inner:
// LINE: LEGO1 0x100bdb50
// LINE: BETA10 0x1013e726 // LINE: BETA10 0x1013e726
column += *data++; column += *data++;
// LINE: BETA10 0x1013e73a // LINE: BETA10 0x1013e73a
@ -452,6 +457,7 @@ void DecodeSS2(LPBITMAPINFOHEADER p_bitmapHeader, BYTE* p_pixelData, BYTE* p_dat
} }
return; return;
// the `while (0)` looks off, but produces the correct `jmp` instructions near the end // the `while (0)` looks off, but produces the correct `jmp` instructions near the end
}
} while (0); } while (0);
} }