From 5e68e038f4c82cad08f8a42744fad668838ba766 Mon Sep 17 00:00:00 2001
From: disinvite <disinvite@users.noreply.github.com>
Date: Thu, 7 Dec 2023 12:07:34 -0500
Subject: [PATCH] MxRegionListCursor edit to prevent accuracy drop

---
 LEGO1/mxregionlist.h | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/LEGO1/mxregionlist.h b/LEGO1/mxregionlist.h
index c36131f3..a308ff4b 100644
--- a/LEGO1/mxregionlist.h
+++ b/LEGO1/mxregionlist.h
@@ -29,11 +29,28 @@ class MxRegionList : public MxPtrList<MxRegionTopBottom> {
 // VTABLE: LEGO1 0x100dcba0
 // class MxListCursor<MxRegionTopBottom *>
 
+// TODO: MxRegionListCursor should probably extend MxPtrListCursor. Doing this has
+// drastically reduced the match percentage for MxRegion::vtable18, so we will replicate
+// the previous cursor hierarchy with this dummy class for now.
+
+template <class T>
+class _ListCursorDummy : public MxListCursor<T> {
+public:
+	_ListCursorDummy(MxList<T>* p_list) : MxListCursor<T>(p_list){};
+};
+
 // VTABLE: LEGO1 0x100dcb88
+class MxRegionListCursor : public _ListCursorDummy<MxRegionTopBottom*> {
+public:
+	MxRegionListCursor(MxList<MxRegionTopBottom*>* p_list) : _ListCursorDummy<MxRegionTopBottom*>(p_list){};
+};
+
+/*
 class MxRegionListCursor : public MxPtrListCursor<MxRegionTopBottom> {
 public:
-	MxRegionListCursor(MxRegionList* p_list) : MxPtrListCursor<MxRegionTopBottom>(p_list){};
+  MxRegionListCursor(MxRegionList* p_list) : MxPtrListCursor<MxRegionTopBottom>(p_list){};
 };
+*/
 
 // VTABLE: LEGO1 0x100dcc40
 // class MxCollection<MxRegionLeftRight *>