Apply feedback by @foxtacles

This commit is contained in:
jonschz 2024-05-03 18:31:52 +02:00
parent 2f8c93508f
commit 5e4d7e5dc2

View File

@ -162,8 +162,7 @@ inline void Matrix4::ToQuaternion(Vector4& p_outQuat)
p_outQuat[0] = (m_data[2][1] - m_data[1][2]) * trace; p_outQuat[0] = (m_data[2][1] - m_data[1][2]) * trace;
p_outQuat[1] = (m_data[0][2] - m_data[2][0]) * trace; p_outQuat[1] = (m_data[0][2] - m_data[2][0]) * trace;
p_outQuat[2] = (m_data[1][0] - m_data[0][1]) * trace; p_outQuat[2] = (m_data[1][0] - m_data[0][1]) * trace;
return; } else {
}
// GLOBAL: LEGO1 0x100d4090 // GLOBAL: LEGO1 0x100d4090
static int rotateIndex[] = {1, 2, 0}; static int rotateIndex[] = {1, 2, 0};
@ -180,11 +179,7 @@ inline void Matrix4::ToQuaternion(Vector4& p_outQuat)
int next = rotateIndex[largest]; int next = rotateIndex[largest];
int nextNext = rotateIndex[next]; int nextNext = rotateIndex[next];
trace = *Element(nextNext, nextNext); float trace = sqrt(*Element(largest, largest) - (*Element(nextNext, nextNext) + *Element(next, next)) + 1.0);
trace += *Element(next, next);
trace = *Element(largest, largest) - trace;
trace += 1.0f;
trace = sqrt(trace);
p_outQuat[largest] = trace * 0.5f; p_outQuat[largest] = trace * 0.5f;
trace = 0.5f / trace; trace = 0.5f / trace;
@ -192,6 +187,7 @@ inline void Matrix4::ToQuaternion(Vector4& p_outQuat)
p_outQuat[3] = (*Element(nextNext, next) - *Element(next, nextNext)) * trace; p_outQuat[3] = (*Element(nextNext, next) - *Element(next, nextNext)) * trace;
p_outQuat[next] = (*Element(largest, next) + *Element(next, largest)) * trace; p_outQuat[next] = (*Element(largest, next) + *Element(next, largest)) * trace;
p_outQuat[nextNext] = (*Element(largest, nextNext) + *Element(nextNext, largest)) * trace; p_outQuat[nextNext] = (*Element(largest, nextNext) + *Element(nextNext, largest)) * trace;
}
} }
// FUNCTION: LEGO1 0x10002710 // FUNCTION: LEGO1 0x10002710