Address review comments

This commit is contained in:
jonschz 2024-07-22 21:52:34 +02:00
parent 049eedbe49
commit 574de7b2a1
6 changed files with 13 additions and 9 deletions

View File

@ -86,6 +86,7 @@ class LegoEntity : public MxEntity {
// FUNCTION: BETA10 0x1000f2f0 // FUNCTION: BETA10 0x1000f2f0
LegoROI* GetROI() { return m_roi; } LegoROI* GetROI() { return m_roi; }
MxU8 GetType() { return m_type; } MxU8 GetType() { return m_type; }
MxBool GetCameraFlag() { return m_cameraFlag; } MxBool GetCameraFlag() { return m_cameraFlag; }

View File

@ -129,6 +129,7 @@ class LegoPathActor : public LegoActor {
// FUNCTION: BETA10 0x1001c860 // FUNCTION: BETA10 0x1001c860
MxU32 GetState() { return m_state; } MxU32 GetState() { return m_state; }
LegoPathController* GetController() { return m_controller; } LegoPathController* GetController() { return m_controller; }
MxBool GetCollideBox() { return m_collideBox; } MxBool GetCollideBox() { return m_collideBox; }
@ -136,6 +137,7 @@ class LegoPathActor : public LegoActor {
// FUNCTION: BETA10 0x10013430 // FUNCTION: BETA10 0x10013430
void SetState(MxU32 p_state) { m_state = p_state; } void SetState(MxU32 p_state) { m_state = p_state; }
void SetController(LegoPathController* p_controller) { m_controller = p_controller; } void SetController(LegoPathController* p_controller) { m_controller = p_controller; }
// SYNTHETIC: LEGO1 0x1002d800 // SYNTHETIC: LEGO1 0x1002d800

View File

@ -62,6 +62,7 @@ class LegoROI : public ViewROI {
// FUNCTION: BETA10 0x1000f320 // FUNCTION: BETA10 0x1000f320
const LegoChar* GetName() const { return m_name; } const LegoChar* GetName() const { return m_name; }
LegoEntity* GetEntity() { return m_entity; } LegoEntity* GetEntity() { return m_entity; }
void SetEntity(LegoEntity* p_entity) { m_entity = p_entity; } void SetEntity(LegoEntity* p_entity) { m_entity = p_entity; }

View File

@ -18,6 +18,7 @@ class MxMatrix : public Matrix4 {
// FUNCTION: BETA10 0x10010860 // FUNCTION: BETA10 0x10010860
float* operator[](int idx) { return m_data[idx]; } float* operator[](int idx) { return m_data[idx]; }
const float* operator[](int idx) const { return m_data[idx]; } const float* operator[](int idx) const { return m_data[idx]; }
// FUNCTION: LEGO1 0x10002850 // FUNCTION: LEGO1 0x10002850

View File

@ -20,22 +20,20 @@ class MxTimer : public MxCore {
return g_lastTimeTimerStarted; return g_lastTimeTimerStarted;
} }
else { else {
return GetTimeElapsed(); return GetTimeSinceStart();
} }
} }
MxLong GetStartTime() { return m_startTime; }
MxBool IsRunning() { return m_isRunning; }
static MxLong GetLastTimeCalculated() { return g_lastTimeCalculated; }
static MxLong GetLastTimeTimerStarted() { return g_lastTimeTimerStarted; }
// FUNCTION: BETA10 0x10017810
MxLong GetTimeElapsed() { return g_lastTimeCalculated - m_startTime; }
// SYNTHETIC: LEGO1 0x100ae0d0 // SYNTHETIC: LEGO1 0x100ae0d0
// MxTimer::`scalar deleting destructor' // MxTimer::`scalar deleting destructor'
private: private:
// This function appears to be public in BETA10; this function may also be
// an older version of GetTime() instead of a private subroutine.
// None of this matters for the release build since these functions are inlined.
// FUNCTION: BETA10 0x10017810
MxLong GetTimeSinceStart() { return g_lastTimeCalculated - m_startTime; }
MxLong m_startTime; // 0x08 MxLong m_startTime; // 0x08
MxBool m_isRunning; // 0x0c MxBool m_isRunning; // 0x0c

View File

@ -41,6 +41,7 @@ class OrientableROI : public ROI {
// FUNCTION: BETA10 0x1000fbf0 // FUNCTION: BETA10 0x1000fbf0
const Matrix4& GetLocal2World() const { return m_local2world; } const Matrix4& GetLocal2World() const { return m_local2world; }
const float* GetWorldPosition() const { return m_local2world[3]; } const float* GetWorldPosition() const { return m_local2world[3]; }
const float* GetWorldDirection() const { return m_local2world[2]; } const float* GetWorldDirection() const { return m_local2world[2]; }
const float* GetWorldUp() const { return m_local2world[1]; } const float* GetWorldUp() const { return m_local2world[1]; }