isledecomp/isle
1
0
Fork 0
mirror of https://github.com/isledecomp/isle.git synced 2026-01-22 15:51:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

improve readability of MxBackgroundAudioManager::Enable

Browse Source 
While the previous iteration wasn't incorrect, it definitely reads like pseudocode (i.e. it's very unlikely any actual developers would have written that). This is much more readable/likely to have been written and still results in the same asm.
This commit is contained in:
itsmattkc 2023-08-03 11:39:21 -07:00
parent 32a7916297
commit 3a28fdae6f
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
LEGO1/mxbackgroundaudiomanager.cpp
View File

@ -31,9 +31,12 @@ void MxBackgroundAudioManager::Stop()
// OFFSET: LEGO1 0x1007f5f0 // OFFSET: LEGO1 0x1007f5f0
void MxBackgroundAudioManager::Enable(MxBool p) void MxBackgroundAudioManager::Enable(MxBool p)
{ {
if ((this->m_musicEnabled != p) && (this->m_musicEnabled = p, !p)) { if (this->m_musicEnabled != p) {
Stop(); this->m_musicEnabled = p;
} if (!p) {
Stop();
}
}
} }
// OFFSET: LEGO1 0x1007f650 // OFFSET: LEGO1 0x1007f650