isledecomp/isle
1
0
Fork 0
mirror of https://github.com/isledecomp/isle.git synced 2026-01-24 08:41:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Address issues raised by linter

Browse Source
This commit is contained in:
jonschz 2024-07-06 20:48:48 +02:00
parent ce52aaccc1
commit 1f141dbe3a
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
LEGO1/lego/legoomni/include/legoanimactor.h
View File

@ -15,7 +15,7 @@ struct LegoAnimActorStruct {
float GetUnknown0x00() { return m_unk0x00; } float GetUnknown0x00() { return m_unk0x00; }
// BETA10: FUNCTION 0x10012210 // FUNCTION: BETA10 0x10012210
LegoAnim* GetAnimTreePtr() { return m_AnimTreePtr; } LegoAnim* GetAnimTreePtr() { return m_AnimTreePtr; }
// TODO: Possibly private // TODO: Possibly private

12
LEGO1/lego/legoomni/src/race/legoracecar.cpp
View File

@ -145,8 +145,8 @@ void LegoRaceCar::FUN_10012ff0(float p_param)
} }
else { else {
// TODO: Possibly an enum? // TODO: Possibly an enum?
const char LEGORACECAR_KICK2 = 4; const char legoracecarKick2 = 4; // original name: LEGORACECAR_KICK2
assert(m_userState == LEGORACECAR_KICK2); assert(m_userState == legoracecarKick2);
a = m_unk0x74; a = m_unk0x74;
} }
@ -172,16 +172,16 @@ void LegoRaceCar::FUN_10012ff0(float p_param)
else if (a->GetAnimTreePtr()->GetCamAnim()) { else if (a->GetAnimTreePtr()->GetCamAnim()) {
MxMatrix transformationMatrix; MxMatrix transformationMatrix;
LegoWorld* current_world = CurrentWorld(); // called `r` in BETA10 LegoWorld* currentWorld = CurrentWorld(); // called `r` in BETA10
assert(current_world); assert(currentWorld);
transformationMatrix.SetIdentity(); transformationMatrix.SetIdentity();
// Possible bug in the original code: The first argument is not initialized // Possible bug in the original code: The first argument is not initialized
a->GetAnimTreePtr()->GetCamAnim()->FUN_1009f490(deltaTime, transformationMatrix); a->GetAnimTreePtr()->GetCamAnim()->FUN_1009f490(deltaTime, transformationMatrix);
if (current_world->GetCamera()) { if (currentWorld->GetCamera()) {
current_world->GetCamera()->FUN_100123e0(transformationMatrix, 0); currentWorld->GetCamera()->FUN_100123e0(transformationMatrix, 0);
} }
m_roi->FUN_100a58f0(transformationMatrix); m_roi->FUN_100a58f0(transformationMatrix);