From 6eca72f69402b512948afd38edbea20a73bda961 Mon Sep 17 00:00:00 2001 From: Anonymous Maarten Date: Tue, 24 Dec 2024 01:04:04 +0100 Subject: [PATCH] fix msvc build --- CMakeLists.txt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index ba94fcee..75847202 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -112,8 +112,10 @@ add_library(Vec::Vec INTERFACE IMPORTED) target_include_directories(Vec::Vec INTERFACE "${CMAKE_SOURCE_DIR}/3rdparty/vec") set(lego1_targets) +set(lego1_interface_targets) macro(add_lego1_static_library NAME) list(APPEND lego1_targets ${NAME}) + list(APPEND lego1_interface_targets ${NAME}-interface) add_library(${NAME}-interface INTERFACE) add_library(${NAME}-objects STATIC ${ARGN}) target_link_libraries(${NAME}-objects PRIVATE ${NAME}-interface) @@ -504,7 +506,7 @@ endif() if (MSVC) if (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "15") - set_property(TARGET ${lego1_targets} APPEND PROPERTY COMPILE_DEFINITIONS "_CRT_SECURE_NO_WARNINGS") + set_property(TARGET ${lego1_interface_targets} APPEND PROPERTY INTERFACE_COMPILE_DEFINITIONS "_CRT_SECURE_NO_WARNINGS") if (TARGET isle) target_compile_definitions(isle PRIVATE "_CRT_SECURE_NO_WARNINGS") endif() @@ -514,7 +516,7 @@ if (MSVC) endif() # Visual Studio 2017 version 15.7 needs "/Zc:__cplusplus" for __cplusplus if (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "19.14.26428") - foreach(tgt IN LISTS lego1_targets) + foreach(tgt IN LISTS lego1_interface_targets) target_compile_options(${tgt} PRIVATE "-Zc:__cplusplus") endforeach() if (TARGET isle)